SEZ9 commented on issue #12542: URL: https://github.com/apache/seatunnel/issues/12542#issuecomment-5945056468
@hutiefang76 thanks for the clear status update and for withdrawing #12543 rather than landing the `TIMESTAMP_S`/`TIMESTAMP_MS`/`TIMESTAMP_NS` regression. Agreed that the query fix is not delivered yet. To confirm the current picture on `dev` at `d7e9931bea0976547e9730675e7019bbef88ad83`: table-path discovery in `DuckDBCatalog` uses the native mapper, but query discovery still inherits `AbstractJdbcCatalog#getTable(String)`, which delegates to the generic `CatalogUtils.getCatalogTable(...)` path. So DECIMAL precision/scale, TIMESTAMPTZ, UUID/JSON/INTERVAL/HUGEINT and the LIST/STRUCT (1111/2003/2002) cases remain broken for `query`. #12592 is intentionally limited to timestamp aliases and local values, so it is related but not a replacement for this issue. Also agreed on STRING for ARRAY/STRUCT/MAP on the query path, consistent with what the native converter already does for `table_path`; the docs grouping correction riding in #12459 is fine, no duplicate PR needed. Two asks for the replacement: 1. Please don't make it depend on #12508, which has not entered `dev`. Unsigned handling in the new PR should stand on its own rather than assume #12508 semantics. 2. Base it on then-current `dev` and include: native query metadata for DECIMAL precision/scale, TIMESTAMPTZ, UUID/JSON/INTERVAL/HUGEINT, and ARRAY/STRUCT → STRING; regression tests for the `TIMESTAMP_S`/`TIMESTAMP_MS`/`TIMESTAMP_NS` aliases and unsigned boundaries; a test showing table-path discovery output is unchanged; and a query-based Source regression in addition to the catalog unit tests. Please link the focused replacement PR here when it's ready and I'll prioritize the review. Keeping this issue open until then. <!-- streview-comment:1461 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
