SEZ9 commented on issue #12542: URL: https://github.com/apache/seatunnel/issues/12542#issuecomment-5964643681
Thanks @hutiefang76 for opening #12610 as the focused replacement. Keeping it independent of the pending unsigned work, leaving `table_path` discovery unchanged, and handling non-UTC local timestamp values separately all match what was discussed here. Before I review, could you add the following to the PR description? 1. Confirmation that it is based on current `dev` (my last check was at `d7e9931bea0976547e9730675e7019bbef88ad83`) and that only the query discovery path changes. 2. The test names covering DECIMAL precision/scale, TIMESTAMPTZ, UUID/JSON/INTERVAL/HUGEINT, and the ARRAY/STRUCT string mapping, so each requested type maps to a specific test rather than the overall count. 3. Confirmation that the `TIMESTAMP_S`/`TIMESTAMP_MS`/`TIMESTAMP_NS` alias and unsigned-boundary tests assert the previously working behaviour, and that the query-based Source regression is separate from the catalog tests. Once upstream CI is green, please mark the PR ready for review and leave a note here. I will keep this issue open until it lands. <!-- streview-comment:1483 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
