DanielLeens commented on issue #12571: URL: https://github.com/apache/seatunnel/issues/12571#issuecomment-5951991556
Thanks for the careful follow-up and for calling out the deviation before asking for review. I checked #12605. Keeping the implementation focused on the `INT`/`INTEGER` numeric branch is the right boundary: `TINYINT` and `SMALLINT` already use their parsing paths to reject overflow, and routing them through a shared numeric helper would risk changing the existing fractional-input behavior. `CAST(... AS FLOAT)` is still outside this change. The new `numberToInt` behavior is an integral-target rule; its handling of non-finite numeric inputs is necessary because they have no representable INT result. `COALESCE` and `IFNULL` that infer an INT target reach the same conversion boundary, so they should not retain silent truncation as an exception. Please keep their regression coverage and the incompatible-change documentation with the PR. The current Build is still running, so the issue remains open and the change is not fixed in `dev` until CI and review finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
