SEZ9 commented on issue #12571: URL: https://github.com/apache/seatunnel/issues/12571#issuecomment-5975670599
@SEPURI-SAI-KRISHNA thanks for the detail on the direct `castAs` coverage. `testCastAsTinyintAndSmallintAlreadyRejectOutOfRangeNumericInput` covering `TINYINT`, `BYTE` and `SMALLINT` with out-of-range input, plus the `5.7d` rejection, is the evidence needed to justify leaving those targets on their existing parsing paths, and `testCastAsIntRejectsOutOfRangeNumericInput` pins the `INT` numeric branch the PR changes. Keeping the change scoped to the `INT`/`INTEGER` numeric branch remains the right boundary for this issue. One thing I'd like confirmed after the latest push: that the `COALESCE`/`IFNULL` regression test (the `-1294967296` case) and the incompatible-changes entry are still included, since they need to land together with the range check. I will continue the rest of the review on the PR. <!-- streview-comment:1494 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
