avnijainnn opened a new pull request, #12607:
URL: https://github.com/apache/seatunnel/pull/12607

   ### Purpose of this pull request
   
   Related to #11007.
   
   Kudu Source, Sink, and Catalog already require `kudu_masters`, but empty or 
whitespace-only values could still pass option validation.
   
   This PR adds `Conditions.notBlank(...)` to the existing required 
`kudu_masters` option in all three factories.
   
   Existing address parsing, Kerberos behavior, table-selection rules, 
defaults, and client construction are unchanged. Valid nonblank values are 
preserved as-is; validation does not trim or normalize them.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes.
   
   Empty or whitespace-only `kudu_masters` values are now rejected during 
option validation. Missing values were already invalid.
   
   Valid values, including comma-separated master lists and values with 
surrounding whitespace, remain accepted unchanged.
   
   ### How was this patch tested?
   
   Added factory validation coverage for missing, empty, whitespace-only, 
valid, comma-separated, and padded nonblank `kudu_masters` values across 
Source, Sink, and Catalog.
   
   `KuduFactoryTest`: 27 tests passed.
   
   Regression proof:
   - removing the Source rule caused 4 expected failures
   - removing the Sink rule caused 4 expected failures
   - removing the Catalog rule caused 4 expected failures
   
   The full `connector-kudu` unit-test suite passed.
   
   Focused Kudu E2E validation for the new invalid Source and Sink 
configurations passed: 14 tests, 0 failures/errors.
   
   `spotless:apply`, `./mvnw -q -DskipTests verify`, and `git diff --check` 
passed.
   
   ### Check list
   
   * [x] No new Jar binary package added.
   * [x] Updated EN/ZH Kudu documentation.
   * [x] Updated `incompatible-changes.md`.
   * [x] Added Kudu E2E validation coverage.
   * [x] No connector registration/distribution changes are required for this 
existing connector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to