DanielLeens commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6059632463
Classification: I / Declarative OptionRule migration tracking. @ryanmeowy, please do not open the proposed MySQL-family CDC PR as written. I rechecked current dev, the runtime validation, the inherited OceanBase path, recent commits, and the open-PR set. The runtime contract requires `startup.specific-offset.file` and `pos` together for `startup.mode=specific`; `gtid-set`, `skip-events`, and `skip-rows` are optional metadata. Adding one generic `.conditional(STARTUP_MODE, SPECIFIC, file, pos, gtid-set, skip-events, skip-rows)` would make all five options mandatory and reject existing valid specific-offset configurations. It would also propagate that incompatibility to OceanBase. The current OptionRule conditional mechanism does not by itself encode the full existing contract: the file/pos pair, nonblank file, optional GTID/skip values, and rejection of specific-offset options outside specific mode. Please first propose a minimal validation design with a compatibility matrix proving that file+pos without GTID/skip remains valid while partial and wrong-mode configurations fail at `--check`; do not broaden the OptionRule DSL or change runtime behavior until that contract is reviewed. No label or assignment changed in this pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
