CryoThrust commented on PR #12740: URL: https://github.com/apache/seatunnel/pull/12740#issuecomment-6164388817
Rechecked `6acc237f` against the two JAVA_HOME requests. The new missing-binary and too-old-JDK paths both include the attempted JAVA_HOME and fix/unset guidance. The shared minimum-version constant also keeps custom-minimum diagnostics consistent. All 21 detector tests pass locally on Python 3.13. I also exercised this head with real Java 8/11/17 on macOS: 11 and 17 resolve correctly; 8 is rejected with its JAVA_HOME value, found version and unset guidance. A missing JAVA_HOME is rejected with the attempted value and recovery hint. This covers the detection helper; I have not tested Windows execution or the complete pip launcher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
