DanielLeens commented on PR #12740: URL: https://github.com/apache/seatunnel/pull/12740#issuecomment-6190133155
Thanks @karthik-0306 for the clear follow-up, and thanks @SEZ9 and @CryoThrust for the extra verification. Nothing further is needed from the code side for my review. One CI correction on my side: in my last review I wrote that the apache-side `Build` check had not started yet. It has now completed on head `6acc237f` with one failed job, `Run / engine-v2-it (11, ubuntu-latest)` (step "run seatunnel zeta integration test"; 82 jobs succeeded and 11 were skipped). This PR only adds two Python files under `tools/seatunnel-python-sdk`, which that Java engine lane does not exercise, so I read this as unrelated to the diff (this is an inference from the diff scope, I did not see the failing test log). The minimal next step is to re-run only that failed job from the fork's Actions run, and no code change is required. My technical approval still stands; the merge itself should wait for a green `Build` and a committer approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
