karthik-0306 commented on PR #12740: URL: https://github.com/apache/seatunnel/pull/12740#issuecomment-6163952618
Pushed an update, rebased on the latest dev. Thanks @DanielLeens for the review. - Added a single DEFAULT_MIN_JAVA_VERSION constant (Issue 2). - If JAVA_HOME points to a Java older than the minimum, the error now includes the JAVA_HOME value and says to fix or unset it, as @SEZ9 asked. Added a test for it. - I left the isfile check as it is (Issue 1): a non-executable file already gives a clear JavaDetectionError through the OSError branch. Happy to add os.access if you prefer. Tests: 28 passed on Python 3.9 and 3.13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
