DanielLeens commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-6181488021
Quick CI follow-up for @li3zhi4 on head `c959fd198`; this is not a new review of the code. My last review (the one tied to this head) said the required `Build` check had not started yet and only the CI gate remained. That fact has changed, so I'm updating it so the earlier guidance does not go stale. **What changed:** the fork run `li3zhi4/seatunnel` actions run 38382232755 (attempt 3) has now finished and `Build` is red. The only failing jobs are `Run / all-connectors-it-2 (11, ubuntu-latest)` and `Run / all-connectors-it-2 (17, ubuntu-latest)`. In both, the failing tests are `CassandraIT.testCassandra` (line 134) and `CassandraIT.testCassandraMultiTableSource` (line 144), in the `TestContainer` run with index `[4]`, which is the Flink 1.20 container; the Flink task manager reports `AllNodesFailedException ... NodeUnavailableException` against the Cassandra container. **My read:** this PR changes `SourceSplitEnumerator` Javadoc, `SourceSplitEnumeratorTask` (comment only), `IncrementalSourceEnumerator` and the MySQL CDC E2E, and nothing on the Cassandra or Flink translation path, so I do not see a link between the diff and these two failures. This is an inference from the diff and the log, not something I could prove. Note that the Cassandra contact-point fix from #12429 is already contained in this head, so a sync with `dev` will not change this lane (the branch is 15 commits behind `dev` and diverged, which is a fact only, not a blocker). **Suggested next step:** please re-run only the two failed jobs rather than the whole workflow. If `CassandraIT` fails again in the same `[4]` Flink container with the same `NodeUnavailableException`, please paste the new failing check link here and I'll help narrow it down against that run. My technical conclusion from the last review is unchanged: no source-level blocker on this head. The remaining gates are the green `Build` and a write-enabled maintainer approval; @SEZ9's pending items are being discussed in the thread with the author. My earlier review entries may still look different in GitHub's review summary because I am a read-only reviewer here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
