DanielLeens commented on PR #11746: URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-6190326900
Quick CI update for @li3zhi4 and @SEZ9 on head `e7586c06a8`; this is not a new review of the code. In my last review I said the fork run (38544126048) had not concluded yet and that the only gate left was a green `Build` with the Oracle and SQL Server split ITs actually executing. That fact has changed, so I am correcting it. The fork run has finished with conclusion `success`, and the apache-side `Build` check on this head is `success` as well. I also grepped the job logs of the `updated-modules-integration-test` lanes rather than relying on the summary status: - `JdbcOracleSplitIT`: `Tests run: 3, Failures: 0, Errors: 0, Skipped: 0` on both JDK lanes where it ran (about 75 s and 69 s), so the Oracle test methods did execute and the `DATABASE IS READY TO USE` timeout seen in the local run did not recur in CI. - `JdbcSqlServerSplitIT`: `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0` on both JDK lanes, followed in the same JVM by `JdbcSqlServerIT` (`Tests run: 10`, zero failures), which is the class-ordering case the `PullPolicy.alwaysPull()` change was meant to protect. So the one gate I listed in my last review (Issue 1) is cleared on this head, and this is the real Oracle coverage @SEZ9 asked for in the last comment. From my side there is still no source-level blocker; the remaining gates are @SEZ9's own open items (which I have not re-derived here, since they are SEZ9's to confirm) and the usual committer approval. I did not execute the PR; this is a static review plus the CI logs of the fork run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
