SEZ9 commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-6228793113
Thanks @CryoThrust for checking the annotations on run `37615433319` directly. Agreed: all 11 failed jobs reporting "repeatedly failed to be acquired (5 attempts)" are runner-acquisition failures, not test executions, so they say nothing about `CheckpointCoordinator` either way. On the F1/F2 scope, your test mapping matches my reading of `de042f22b`: - F1 (rejection / shut-down pool): `testCheckpointErrorReportRejectionStillReachesCancellationOffCallerThread` drives a shut-down primary executor and confirms `handleCheckpointError` is delivered off the caller thread via the fallback; `testCheckpointErrorReportCompletesFutureWhenExecutorRejects` covers the waiter-release side. That addresses the silent-drop / restore-hang concern. - F2 (propagation after release): `testCheckpointErrorReportDoesNotRunOnCallerThread` now verifies `handleCheckpointError(1, false)` once the busy executor is released, not just that the caller returns. - Double rejection (both pools): agreed this is not covered and is not reachable without a seam into the private static fallback pool. Keeping it as the explicitly tracked follow-up is fine with me; I would rather not add reflection-based tests here. So from the code side there is nothing further on F1/F2. Remaining asks: 1. Please re-enable workflows on the fork from the signed-in Actions page, since the queued rerun will not start while they are paused. 2. Once a run for `de042f22b` actually executes, post the outcome here. If any job fails with a genuine test failure, paste the job and test name so we can classify it. 3. If the rerun keeps sitting in the queue after workflows are re-enabled, syncing the branch with `dev` to trigger a fresh run is an acceptable fallback. I will take another look as soon as there is a completed run on this head. <!-- streview-comment:1815 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
