SEZ9 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-6229091986
@Vivek1106-04 thanks for following up on the benchmark concern @nzw921rx raised. The analysis and sweep in https://github.com/apache/seatunnel/pull/12418#issuecomment-6135494803 is the right way to settle this before drawing efficiency conclusions from this PR. Agreed on the sequencing you proposed. Two requests from my side: 1. Once the benchmark fix is merged, please rerun the comparison of this PR against `dev` with the fixed harness and post the result on this PR as well, not only on #12418. 2. If the rerun requires any new commit on top of `c773cc091`, or you sync with `dev` first, please call that out so the earlier CI attribution can be redone on the new head rather than carried over. My review on `c773cc091` is unchanged; the final look for the merge remains with a committer. <!-- streview-comment:1825 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
