hutiefang76 opened a new issue, #12874:
URL: https://github.com/apache/seatunnel/issues/12874

   ### Search before asking
   
   - [x] Searched open/closed issues and PRs. #12792 introduced the source 
option; no follow-up for the completeness test was found.
   
   ### What happened
   
   `JdbcOptionRuleCompletenessTest.testSinkRuleDeclaresAllSinkOptions` fails on 
clean dev after #12792: it reflects the inherited 
`JdbcCommonOptions.NUMERIC_SPECIAL_VALUE_AS_NULL` field and expects the sink 
rule to accept `numeric_special_value_as_null`.
   
   The merged PR and English/Chinese source documentation explicitly define 
this as a source-only PostgreSQL read option. `JdbcSourceFactory` declares it 
and the input/row-read path consumes it; `JdbcSinkFactory` correctly does not 
declare it. The test's reflection currently has a sink-only exclusion for 
source coverage (`SCHEMA`), but no corresponding source-only exclusion for sink 
coverage.
   
   Clean baseline: **2 tests, 1 failure, no errors/skips**, reproduced 
separately from any production changes. The full JDBC suite also fails at this 
same test (1,156 selected JDBC tests in the truncate worktree, one failure, no 
errors).
   
   I will scope sink completeness coverage to exclude this documented 
source-only option and add a guard proving the source accepts its key while the 
sink continues to reject it. All other reflected options will remain covered. 
This is a test correction; no production option, default, or parser behavior 
changes.
   
   ### SeaTunnel Version
   
   Dev `e2957d27afa29d4de4324cf642450757d865b902`.
   
   ### SeaTunnel Config
   
   No database/engine job needed: test calls 
`ConfigValidator.validateUnknownKeys` with the actual JDBC factories' option 
rules.
   
   ### Running Command
   
   ```sh
   ./mvnw -pl seatunnel-connectors-v2/connector-jdbc -am \
     -Dtest=JdbcOptionRuleCompletenessTest \
     -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false package
   ```
   
   ### Error Exception
   
   ```text
   Connector 'Jdbc' has unknown option keys: [numeric_special_value_as_null]
   Tests run: 2, Failures: 1, Errors: 0, Skipped: 0
   ```
   
   ### Java or Scala Version
   
   JDK 17.0.18, macOS ARM64.
   
   ### Are you willing to submit PR?
   
   - [x] Yes, I am contributing this fix to Apache SeaTunnel.
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's Code of Conduct.
   
   <sub>Reproduction and report prepared and posted by an AI assistant for 
@hutiefang76.</sub>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to