SEZ9 commented on issue #12874: URL: https://github.com/apache/seatunnel/issues/12874#issuecomment-6308208150
Thanks @fatmanverse for the follow-up and for verifying the move against `dev` e2957d2 on JDK 17. Nothing has changed on my side: #12875 stays as the small test correction — the named exclusion for the single source-only key `numeric_special_value_as_null`, plus the regression that checks source acceptance and sink rejection. That is the lane to unblock CI, so please don't open a competing test-fix PR, and I won't fold the move into #12875. On relocating `NUMERIC_SPECIAL_VALUE_AS_NULL` from `JdbcCommonOptions` to `JdbcSourceOptions`: your notes that it is only referenced in `JdbcSourceFactory#optionRule` and `JdbcConnectionConfig`, that the CDC `*IncrementalSourceOptions` classes extend a different `JdbcSourceOptions` class, and that #12792 is not yet released are useful groundwork. But moving a public constant is still a separate source/API change, so I'd rather it get explicit maintainer agreement on its own than ride along with a CI fix. Concrete asks: - Hold the move until #12875 has landed. - If you then want to propose it, open it as a separately scoped PR (not a test fix) and spell out in the description what you already listed here: key/type/default/description unchanged, the three `JdbcConnectionConfig` references updated, the `JdbcSinkFactoryTest` sink-rejection case, and the check that `connector-cdc-postgres` / `connector-cdc-mysql` are unaffected. I'll keep this issue focused on the completeness-test failure and close it once #12875 is merged. <!-- streview-comment:1925 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
