SEZ9 commented on issue #12874: URL: https://github.com/apache/seatunnel/issues/12874#issuecomment-6432165441
@fatmanverse thanks for following up and opening #12989 as a separately scoped PR instead of folding the move into the CI fix. That is exactly the sequencing asked for here: the test-side exclusion from #12875 landed via #12938 on `dev` eceeb0a first, and the move to `JdbcSourceOptions` is now proposed on its own. From your description, #12989 covers the points that were asked for a standalone proposal: - key/type/default/description of `numeric_special_value_as_null` unchanged; - only the three `JdbcConnectionConfig` references repointed, with no CDC or other connector referencing the constant; - `NOT_SINK_OPTIONS` exclusion removed from `JdbcOptionRuleCompletenessTest`, while `testNumericSpecialValueAsNullIsSourceOnly` keeps asserting source acceptance and sink rejection; - JDK 17 verification of `connector-jdbc` plus `connector-cdc-postgres` / `connector-cdc-mysql` builds. Remaining asks, which I will check on the PR itself rather than here: 1. Please make sure #12989 links back to this issue and to #12938 so the exclusion-removal is traceable to the fix it supersedes. 2. Keep the regression test as the guard: if the exclusion is gone, `testNumericSpecialValueAsNullIsSourceOnly` is the only thing enforcing that the sink still rejects the key, so it should stay in the PR unchanged. 3. Since the constant moves from `JdbcCommonOptions` to `JdbcSourceOptions`, call out in the PR description that this is a public-constant relocation (even though the config key is unchanged and the option from #12792 is not yet released), so reviewers can judge the API impact explicitly. @hutiefang76 nothing further needed on your side for this issue; the test-scope correction is in, and the relocation discussion continues on #12989. I'll leave this issue open until that review concludes, then close it. <!-- streview-comment:2061 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
