SEZ9 commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6282986261
Thanks @Rangsh for going through both failure logs on fork run 38496659794 (head `35f5a2fcf7c`). Your reading matches what I see: - `engine-v2-it (11)` (job 115650597710) is still the known `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` cancel-vs-worker-loss race (`expected: <CANCELED> but was: <FAILED>`). It does not go through a failed `deployLocalTask`, and #12311 is not on `dev` yet, so no action from this PR will clear it. Not a blocker here. - `kafka-connector-it (17)` (job 115650597797) fails only in the Testcontainers image build (`received unexpected HTTP status: 500 Internal Server Error`) before any Kafka test logic runs, and the same test passes for the other engine parameters in that job. That is a registry/runner flake, unrelated to this change. Since the head has not moved since `35f5a2fcf`, this is a follow-up rather than a fresh review, and I agree no speculative source patch is wanted for either failure. Remaining asks, both small: 1. When you next sync the branch with `dev`, please post the new fork run link so we can confirm `kafka-connector-it (17)` goes green on a clean build. No need to do it just for that; whenever your next push happens is fine. 2. Nothing else on the source side from this round. Once that run is in, this is ready for committer approval and merge. Thanks for the patience across these iterations. <!-- streview-comment:1900 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
