SEZ9 commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6356288434
@Rangsh Thanks, that matches my read of the thread — no further source change is needed from you for this fix. To confirm where things stand on head `35f5a2fcf7c9ad52f25f07d299a2f918925ebd19`: - `engine-v2-it (11)` (job 115650597710): the `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` cancel-vs-worker-loss race does not go through the changed `deployLocalTask` path, and since #12311 is still open, a `dev` sync alone will not clear it. We will keep treating it as unrelated to this PR. - `kafka-connector-it (17)` (job 115650597797): the `received unexpected HTTP status: 500 Internal Server Error` from the Testcontainers image build happens before any Kafka test logic runs, so it is a registry/runner flake, not something this PR introduced. Remaining items: 1. Whenever you next push (e.g. a sync with `dev`), that will give us a fresh fork run for the Kafka lane. If `KafkaIT.testNativeSinkKafka` then fails on an executed assertion rather than the image build, please post the new job link here as you offered; otherwise a green Kafka lane is all we need from that job. 2. Once CI on the final head is acceptable, the remaining gate is a write-capable maintainer's approval. As a read-only reviewer I cannot do the formal approval, but there is nothing more for you to do there. Thanks for the careful log reading and the patience across these rounds. <!-- streview-comment:1965 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
