SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-6308580695
Thanks for the detailed F1–F8 table against `d2f8193c97`. That gives me what I need to re-check each item directly in the diff, so I won't ask for the pointers again. Since the table was based on a source read only, it would still help if the author could confirm that the referenced tests pass locally on `d2f8193c97`. One small suggestion on F7: if the `assigned == completed + running` check is only enforced when all three counts are `EXACT`, a one-line Javadoc note on the constructor stating that condition would help future implementers understand why the counts are not cross-checked otherwise. I'll go through the diff against the F1–F8 points and follow up with anything that remains. <!-- streview-comment:1929 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
