SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-6331944772
Quick follow-up on head `d2f8193c97`, staying within the F1-F8 scope from the earlier review. **Tests:** since the `Build` check is green on this head, the referenced `CdcProgressModelTest` and `ReportCdcProgressOperationSerializationTest` are already exercised in project CI. A separate local run is optional from my side. **F7 (count invariants):** the checked cross-validation in `validateExactSplitCounts` covers the behaviour, so the only piece still open is documentation. Neither the class Javadoc nor the constructor of `CdcEnumeratorProgressReport` currently states that the `assigned == completed + running` invariant is enforced only when all three counts are `EXACT`, which leaves connector authors passing `ESTIMATED` or `UNKNOWN` counts without a hint as to why they are not cross-checked. A short constructor Javadoc along these lines would close F7: - counts must be non-negative; - `assigned == completed + running` is enforced only when all three accuracies are `EXACT`. **Remaining asks before the final pass:** 1. Add the F7 constructor Javadoc described above. 2. Sync the branch with `dev` — `mergeStateStatus` is currently `DIRTY`, so it cannot be merged as-is. Both can go in the same push. Nothing else from F1-F8 is open on this head from my side. Thanks for sticking with the review! <!-- streview-comment:1944 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
