DanielLeens commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6338469055
Thanks @SEZ9. The earlier green run you cited is for `612b5ede5`, whereas the current head is `b190936bbbcb82f4758aeff6b7f565f44d16739a`. Its Build run 39254498031 is failed, so the older success cannot serve as the current-head gate. The inspected unit log fails `JdbcOptionRuleCompletenessTest.testSinkRuleDeclaresAllSinkOptions` on `numeric_special_value_as_null`; `jdbc-connectors-it-part-1 (17)` also stops before tests because Maven cannot resolve the os-maven-plugin extension dependencies, including commons-lang3:3.5, from Central. That is a bootstrap/dependency-resolution signal, for which a targeted retry after repository availability recovers is more informative than changing this parser fix. Fix #12875 is still open and current dev retains the fixture mismatch, so syncing alone is not yet a cure for that unit failure. My previous source-level conclusion remains clear, with the migration/comment notes non-blocking; your direct verification remains yours to close. Separately, GitHub currently reports real conflicts against dev. Please resolve those conflicts, and once the shared JDBC correction is available, include it and rerun the affected checks on the resulting head. I will re-review the full updated diff after a new commit. This follow-up does not repeat the earlier source review or declare current CI green. Current status evidence: head `b190936bbbcb82f4758aeff6b7f565f44d16739a`, base `dev`, compare `diverged` (ahead 17, behind 18), mergeable state `dirty`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/118096461689), [Run / unit-test (11, ubuntu-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/39254498031/job/118067455644), [Run / jdbc-connectors-it-part-1 (17, ubuntu-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/39254498031/job/118067456865). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
