SEZ9 commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6432483539
Thanks for the detailed pointers on `9152a91fa278`. That mapping of each earlier point to specific tests and the incompatible-changes entries is helpful, and the description of the intended behaviour (each output ID releasing its waiting list once, the terminal fallback retained, a single shared input-ID resolver, self-cycle rejection with matching wording) lines up with what I was looking for. I can't mark the findings resolved from the comment alone, though. I'll go through the diff on this head and confirm the tests and docs changes directly before updating the review. Two things in the meantime: 1. Your comment appears to be cut off right at the open item you mentioned on `ConfigParserUtil.getInputIds`. Could you post the rest of that sentence, and say whether you plan to address it in this PR or in a follow-up? 2. On the duplicated ready-scheduler point: could you confirm explicitly where the dry-run validator and the runtime parser converge on a single scheduler implementation, or point me at the shared code? That drift concern was the core of that finding. Once I've verified against the diff and have those two clarifications, I expect this to be close to ready. <!-- streview-comment:2074 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
