SEZ9 commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6538752169
Thanks for the follow-up on 67f3bde2506a. Going through the earlier points against what is described so far: - **PR12079-F1 (duplicate output IDs double-releasing joins):** Counting distinct missing input IDs and removing the `waitingByInputId` entry per output ID so a repeated producer satisfies an ID only once is the fix I was after. Could you point me to the hunk and the test that covers two transforms sharing a default output ID feeding a multi-input transform, so I can confirm it on the diff? - **PR12079-F6 (single-transform self-cycle slipping through the fallback):** Running Kahn cycle detection before the terminal fallback sounds right. Is there a test asserting that an explicit self-cycle fails with a concrete cycle path instead of entering the fallback? - **PR12079-F7 (user-facing behavior change without docs):** Method contracts help, but the finding was about user-facing docs/changelog/upgrade notes for the new fail-fast rejection. Could you link the docs or release-note change, or let me know if you prefer to handle it separately? - **PR12079-F5 (scheduler duplicated between dry-run and the Zeta parser):** Please confirm the dry-run path no longer carries its own scheduler copy and delegates to the shared one. - **PR12079-F2 / PR12079-F4 (legacy terminal fallback narrowed):** Can you confirm a multi-transform job whose last transform omits `plugin_input` still dry-runs successfully via the terminal omitted/empty branch, ideally with a test covering that shape? That is the compatibility case I still can't tell from the summary. - **PR12079-F3 / PR12079-F8 (scheduling vs. validation ID resolution, unused `getOutputId()`):** Non-blocking from my side; if you leave them as is, a brief note on why dry-run keeps its own resolution helpers would be enough. Concrete asks before I approve: (1) diff/test pointers for F1 and F6, (2) the multi-transform omitted-`plugin_input` confirmation or test for F2/F4, (3) a word on the docs/changelog plan for F7. <!-- streview-comment:2163 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
