DanielLeens commented on PR #12906: URL: https://github.com/apache/seatunnel/pull/12906#issuecomment-6397512747
Thanks for the contribution. One merge-state fact in my previous review is now obsolete: this branch is no longer level with dev and mergeable. GitHub now reports **DIRTY / merge conflicts** for the unchanged head `e2f12fcea7146f82074d6ea05b63ebe5a8f796ac`. The recorded comparison is `diverged`, ahead by 3 and behind by 37 against dev. Please sync the latest dev and resolve the conflicts, then run Build on the resulting new head. This request is for the reported conflicts, not merely because the branch is behind. The old [fork Build 39428159076](https://github.com/hutiefang76/seatunnel/actions/runs/39428159076) remains cancelled; it has not become a passing result. Cancellation is not evidence of an Avro code failure, and adding an unrelated patch to chase it is unnecessary. My earlier source conclusion remains unchanged: the reviewed ByteBuffer ownership/bounds fix has no remaining code-side blocker from Daniel. After conflict resolution, the new head needs a full re-review and current-head CI. This is a merge-gate correction, not a fresh source review or effective approval. A write-capable maintainer must handle the final repository approval gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
