DanielLeens commented on PR #12902: URL: https://github.com/apache/seatunnel/pull/12902#issuecomment-6397816583
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/hutiefang76/seatunnel/actions/runs/39772122616) is now **completed with failure** for `91d1078a3790cf0bcdfbda5cd235c28ec8a95219`. This is a gate correction, not a second full source review of that unchanged head. The inspected [Java 17 resource-managers job](https://github.com/hutiefang76/seatunnel/actions/runs/39772122616/job/120703046042) fails in `KubernetesApplicationRecoveryIT.durableCheckpointRestoresSourceProgressAfterWorkerFailure`: `livePodLogs(...)` returns null and line 65 immediately calls `.contains(marker)`. This is a shared Kubernetes IT readiness/log assertion, outside this PR's file-read change. The connected read API returned one page of jobs, so this is a verified failing sample, not a claim that no other matrix leg failed. I compared that test with latest dev: the same null-unsafe assertion remains and no matching fix was found there. Syncing current dev alone is therefore not a demonstrated solution. Please retrigger the failed resource-managers job once; if the same signature persists, a separate shared-test fix should wait for non-null pod logs before checking the marker, retaining the real durable-checkpoint/restore assertions. Keep that framework fix separate from this PR. The earlier LLM serial-UID correction is already in this head and does not address this new failure. Comparison against dev is `diverged`, ahead 4 / behind 25; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
