SEZ9 commented on PR #12619: URL: https://github.com/apache/seatunnel/pull/12619#issuecomment-6406955670
@goutamadwant thanks for adding the checklist to the PR description — that helps when going back over the earlier review points. Before I can close any of them out, I need to verify the changes themselves rather than the checklist descriptions. Could you point me at where on `441ee3e5f8331c0038f7d1fb2a024087f4ce20ac` each of the following is handled, so I can confirm it against the diff? - **F1** – the retained-bytes guard in `JobLineageProjector`: is it now checked per retained node name / table path rather than after the whole list is materialized, and does the inline comment match the actual behavior? - **F2** – non-positive job IDs: are they now accepted, and which test covers `0` and negative values? - **F3 / F5** – empty `TablePath` and mixed null/`TablePath.DEFAULT` entries: how is `datasetMetadata` derived so that `REPORTED` and the `DATASET_METADATA_UNAVAILABLE` warning can no longer both appear for the same node? - **F6** – `JobLineageException`: where is the expected HTTP status mapping for `Reason` documented? Documenting it is fine for this PR since nothing calls `project()` from a servlet yet. - **F7** – `JobLineageLimits.DEFAULT`: where are the fixed values and their non-configurable status documented? - **F8** – null `limits`: where is the null check and its test? On **F4**, your comment says logical-DAG test coverage is the one deferred item and that an existing bug will be handled in a separate PR. Could you spell out exactly what is and isn't covered at this head — in particular (a) whether the TRANSFORM / `NOT_APPLICABLE` branch is exercised against real `DAGUtils` output, and (b) which logical-DAG scenario is deferred and what the bug is? If a follow-up issue exists, please link it from the checklist so the deferral is traceable. Once I can see the diff for each of these I'll go through them again. <!-- streview-comment:2040 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
