goutamadwant commented on PR #12619:
URL: https://github.com/apache/seatunnel/pull/12619#issuecomment-6651162876

   @SEZ9 On F4:
   
   (a) Covered: `projectsTransformFromPhysicalDagInfo` 
([L133-L192](https://github.com/apache/seatunnel/blob/441ee3e5f8331c0038f7d1fb2a024087f4ce20ac/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/rest/lineage/JobLineageProjectorTest.java#L133-L192))
 runs `lineage_transform.conf` through `DAGUtils.getJobDAGInfo(..., true, ...)` 
and asserts the TRANSFORM node, `NOT_APPLICABLE` and empty table paths. Both 
engine-backed tests use the physical flavour, the only one production builds 
(`JobMaster`, `CoordinatorService` and `BaseService` all pass `true`).
   
   (b) Deferred: the logical flavour, `getJobDAGInfo(..., false, ...)`, for any 
job with an edge. It matches `p.getActions().containsKey(action.getId())`, but 
`getActions()` is keyed by `ActionStateKey`, so `.findFirst().get()` always 
throws ([DAGUtils 
L163-L182](https://github.com/apache/seatunnel/blob/441ee3e5f8331c0038f7d1fb2a024087f4ce20ac/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/DAGUtils.java#L163-L182)).
 A fix also has to map chained transforms and union-split pipelines. I will 
open the fix as its own issue and PR once it is verified locally, and link both 
from the checklist.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to