DanielLeens commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6411617918
Hi @201811510411lw, thanks for the quick and clear update, and @SEZ9 thanks for the careful follow-up. Your plan sounds right to me. I re-checked the two upstream items you mention: both [#12316](https://github.com/apache/seatunnel/pull/12316) and [#12313](https://github.com/apache/seatunnel/pull/12313) are still open and not in `dev`, so syncing now would not change the `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure` result. Waiting for one of them, then merging `dev` and rerunning only the failed engine leg (plus the cancelled leg, if it is still required), is the least wasteful path. The Paimon routing change itself stays untouched. On SEZ9's question about the merge commit `516b855e`: I compared it with the previous head `ab3fcc09` (static read, nothing run locally). The commit has two parents, and the changed paths are the `dev`-originated ones. The only files that appear in both that list and this PR's own file list are `docs/en/introduction/concepts/incompatible-changes.md`, `docs/zh/introduction/concepts/incompatible-changes.md` and `docs/zh/connectors/sink/Paimon.md`. None of the PR's API, Paimon, Flink starter or E2E files changed. So a one-line confirmation from you that the three docs were merged without hand-editing your own entries would settle it. No new code is needed from you right now, and my earlier source-level conclusion is unchanged. When you merge `dev` again (a plain merge, as SEZ9 suggested), I will check the new head and the Build result. Thank you for keeping this PR focused! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
