DanielLeens commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6414890031
Hi @201811510411lw, thank you for confirming this so quickly. Your note that `516b855e` was a plain merge of `dev`, with no manual edits to the three PR-owned doc entries (the English and Chinese incompatible-changes pages and the Chinese Paimon sink page), matches what I saw when I compared it with the previous head `ab3fcc09` by reading the diff. That closes the question @SEZ9 raised and my follow-up on it, so there is nothing left open on the merge-commit point from my side. Current state, to keep the plan clear: - The head is still `516b855e`, so my earlier source-level conclusion on the Paimon fixed-bucket routing is unchanged and no new code is needed from you. - The only red item is the shared `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure` engine leg, which is outside this diff. The fix in #12316 is still open and not in `dev`; it just received a new head and its CI is pending, and #12313 is also still open. Syncing now would not change that result, so your plan to wait is still the least wasteful path. - Once one of them lands, please do a plain `dev` merge (as @SEZ9 suggested, so the review history stays intact) and rerun only the failed engine leg, plus the cancelled leg if it is still required. I will check the new head and the Build result then. Thanks again for keeping this PR focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
