DanielLeens commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6397819922
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/201811510411lw/seatunnel/actions/runs/39887766009) is now **completed with failure** for `516b855e1637322d5275503c5fc6b85235f26bdf`. This is a gate correction, not a second full source review of that unchanged head. The [Java 11 engine job](https://github.com/201811510411lw/seatunnel/actions/runs/39887766009/job/120200866820) failed in `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure`, with only one additional checkpoint completed in 90 seconds. The overall run has now completed with failure, replacing the previous in-progress description. A cancelled connector leg does not count as a pass either. The unchanged shared engine test and still-open [#12316](https://github.com/apache/seatunnel/pull/12316) were rechecked against latest dev. There is no demonstrated merged fix for this checkpoint-handoff signature, so syncing alone is not the answer. Please rerun the failed engine leg and any required cancelled leg, and keep a repeated engine failure with that upstream investigation rather than changing the Flink/Paimon routing in this PR. Comparison against dev is `diverged`, ahead 10 / behind 14; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
