karthik-0306 commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6421748009
Thanks @DanielLeens. I took the optional Issue 1 in the latest commit: `select_plugins(...)` now runs inside the rollback `try`, so an interrupt right after the rewrite is rolled back too (`test_interrupt_right_after_the_rewrite_is_rolled_back`, which fails on the previous head). While re-reading the module line by line I also closed the same error-contract gap @SEZ9 pointed out for `connectors=None`, but for `seatunnel_home`: `None`, a number or a `bytes` path now raise `PluginInstallError` instead of a raw `TypeError`. All 67 SDK tests pass on Linux with Python 3.9, 3.10 and 3.13 (lock test included), and on Windows with 3.9 / 3.11 / 3.13 (lock test skipped, no `fcntl`). About the red `Test with Python 3.9` check: it fails at "Set up Python" before any test runs, because `ubuntu-latest` is now Ubuntu 26.04 and `setup-python` has no 3.9 build for it. That affects every SDK PR, so I've opened #12994 to pin the SDK workflow to `ubuntu-24.04` instead of mixing it into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
