SEZ9 commented on PR #11602: URL: https://github.com/apache/seatunnel/pull/11602#issuecomment-6487228085
Thanks for the follow-up. A quick note on where things stand from my side. **CI gate** As of my last check, [Build](https://github.com/apache/seatunnel/runs/121486172860) on head `e25b3354e65afa6dec118820cb187f87f24a2a72` was `ACTION_REQUIRED`, blocked at the fork Build workflow-run detection stage (no fork Build run found for that SHA). That is not an executed test failure, so nothing in the source is being flagged by it. I have not re-checked the aggregate since that snapshot, so if it has moved, please say so. What would help: 1. Open the Actions tab on your fork and enable workflows if they are disabled. 2. Manually run the existing Build workflow for this PR branch at the reviewed head. 3. If a matching run for this SHA already exists, link it here so a maintainer can reconcile the aggregate. No empty commit or dependency change is needed for this; a run on the unchanged head is what is missing. **Source review** My [previous source conclusion](https://github.com/apache/seatunnel/pull/11602#pullrequestreview-5643679538) still stands as written, including the documentation correction noted there (the per-job JobMaster path is bounded per worker, not by one overall deadline). Nothing new is being raised on the code in this comment. Once a fork Build run exists for `e25b3354e65afa6dec118820cb187f87f24a2a72`, I'll take another look. CI is not being passed by inference, so this is not an approval yet. <!-- streview-comment:2119 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
