SEZ9 commented on PR #11602: URL: https://github.com/apache/seatunnel/pull/11602#issuecomment-6538897386
Thanks for the follow-up on this PR. Nothing has changed on head `e25b3354e65afa6dec118820cb187f87f24a2a72`, so the status is the same as in the earlier source conclusion (review 5643679538): 1. **JobMaster documentation (still open):** the existing text describes a single overall deadline, but the actual bound is applied per worker. Please update the documentation to state that it is a per-worker bound rather than one overall deadline. This is the only remaining source/documentation ask from the previous review; no other code change is being requested here. 2. **Build gate (still `ACTION_REQUIRED`):** [Build](https://github.com/apache/seatunnel/runs/121486172860) has not detected a fork workflow run for this exact head, while [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40168025208/job/121480713925) is `SUCCESS`. Please check the Actions tab on your fork: enable workflows only if they actually show as disabled, then start the existing Build workflow for this branch. If a matching run already exists, link it here so it can be reconciled. An empty commit, base sync or dependency change will not by itself supply the missing exact-head run, so none of those are being requested. Once the doc wording is corrected and an exact-head Build run is available, I'll take another look. Please note this comment is a clarification on the unchanged head, not an approval. <!-- streview-comment:2170 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
