SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6487887241
Quick follow-up on CI for head `4b80eba2519f8a1d13a54229dbd2090d7fca8a9f`: the [Build](https://github.com/apache/seatunnel/runs/122671703070) run is `FAILURE`. Blocking jobs: [Run / unit-test (17, windows-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/40644985034/job/122672493389) `failure`, [Run / unit-test (11, windows-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/40644985034/job/122672493392) `failure`, plus the cancelled [Run / all-connectors-it-3 (17, ubuntu-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/40644985034/job/122672494118), [Run / all-connectors-it-3 (11, ubuntu-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/40644985034/job/122672494137) and [Run / connector-file-local-it (11, ubuntu-latest)](https://github.com/goutamadwant/seatunnel/actions/runs/40644985034/job/122672494528). The log shows `maven-failsafe-plugin:2.22.2:integration-test (default) on project seatunnel-resource-managers-e2e: No test s were executed!`, which identifies the failing stage but doesn't by itself show whether this PR caused it. Asks: 1. Please take a look at the two Windows unit-test failures and the `seatunnel-resource-managers-e2e` failsafe error, and either rerun those jobs if a rerun is appropriate or post a short note on the root cause. Please avoid unrelated module/dependency changes unless you've confirmed they are the actual fix. 2. The points from the [previous review](https://github.com/apache/seatunnel/pull/11307#pullrequestreview-5681328887) still apply to this head as far as I can see; let me know if any have already been addressed: - PR11307-F1 (HIGH): in `start-seatunnel-spark-3.5-connector-v2.cmd`, `setlocal disabledelayedexpansion` runs before `!errorlevel!`/`!CMD!` are expanded, so the `call` target is the literal text `!CMD!` and the job never runs. - PR11307-F5: the same `.cmd` exits 0 when the starter java process fails with no stdout, and `for /f` hides java's real exit code. - PR11307-F2 / F6: in `start-seatunnel-spark-3.5-connector-v2.sh`, the `eval` over the assembled command line executes config-controlled content, and `args=$@`, `${args}` and `${CLASS_PATH}` are unquoted. - PR11307-F3: the 3.5 starter shades `seatunnel-translation-spark-3.3`; please describe how Catalyst binary compatibility against Spark 3.5.8 was verified. - PR11307-F4: both `log4j-slf4j-impl` and `log4j-slf4j2-impl` land in `starter/logging/*`, which both launchers put on the classpath. - PR11307-F7: the docs point Spark 3.5 users at the streaming template, but the new tests only cover the row encoder and batch write. - PR11307-F8: `docs/en/engines/spark.md` narrows `seatunnel-spark-3-starter.jar` to "Spark 3.3.x" and leaves 3.4.x users without guidance. Once the Windows launcher (F1/F5) and shell quoting/eval items (F2/F6) are fixed and the named jobs are green, I'll take another pass. Thanks for the work on this. <!-- streview-comment:2125 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
