DanielLeens commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6503442310
Thanks @SEZ9 for making the concerns explicit. I fetched and rechecked the exact current head against those points. Several describe earlier versions: the Windows launcher now runs java directly and saves %errorlevel% before FOR /F (start-seatunnel-spark-3.5-connector-v2.cmd:53-64), then calls spark-submit.cmd with %CMD% at :79; it no longer invokes literal !CMD! or loses the java status. The Unix launcher uses a NUL-separated argument file, arrays and quoted argv at .sh:73-91, with no eval. The new starter POM excludes log4j-slf4j2-impl; TestSpark35StarterJarContentIT:75-88 checks exactly one SLF4J 1.7 binding and no SLF4J 2 provider. docs/en/engines/spark.md:19-39 retains 3.4 guidance, limits the public 3.5 launcher to batch, explains the bounded micro-batch test and explicitly states the remaining Catalyst/native-Windows validation limits. Reusing the 3.3 translation layer is therefore a documented, bounded compatibility claim, not proof of every 3.5 path. I am not reopening th e addressed source findings from stale snippets. CI still needs resolution: both Windows unit steps stop in seatunnel-resource-managers-e2e with No tests were executed, and three connector/file shards are cancelled. Latest dev has the same resource-manager Failsafe selection and no verified fix for that exact failure; a sync alone is not a demonstrated cure. Have the CI owner inspect the skipIT/test-selection propagation and rerun the named failed/cancelled jobs; do not change the repaired Spark launcher speculatively to chase that unrelated stage. Checked 2026-10-29T17:14:45+00:00; head `4b80eba2519f8a1d13a54229dbd2090d7fca8a9f`. [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40644991988/job/122671615702) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/122671703070) = `FAILURE` Comparison: base `dev`, head `4b80eba2519f8a1d13a54229dbd2090d7fca8a9f`, `diverged`, ahead 69 / behind 61; GitHub mergeable state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. Daniel has READ repository permission. This is a discussion/CI clarification, not a new complete source review, an effective APPROVED event or dismissal of historical requested changes. A write-capable maintainer must perform any required final approval/dismissal. Thanks for keeping the follow-up focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
