SEZ9 commented on PR #12922: URL: https://github.com/apache/seatunnel/pull/12922#issuecomment-6513247331
@fatmanverse thanks for the follow-up on 98a2be8. Points 1–3 as described match what I was asking for: 1. **All-or-nothing `/submit-jobs`** – making `JobInfoService#submitJobs` validate every entry before submitting anything is exactly the fix, and `testInvalidLaterEntryRejectsTheWholeRequest` with a valid first entry and an invalid second one also covers the mixed-order case I raised. Please make sure it asserts on the submitted-job count rather than only the HTTP 400, so a regression that submits entry 0 before failing on entry 1 is caught. 2. **Blank `jobId`** – `StringUtils.isBlank` in `checkStartWithSavePoint` resolves this, and sharing the behaviour with the v1 `/submit-job` savepoint path is a welcome side effect. 3. **Non-integral / oversized numbers** – rejecting values such as `9223372036854775808` in `toStringParams` with `'params' number values must be integers within the long range` before submission is what I wanted. Your comment appears to be cut off at the end of point 3, so I can't see what you did for the remaining points. Could you post the rest, specifically: - which test now covers the `null`-value skip and empty-string acceptance in `params`; - whether the `params` table in the v2 REST docs now reflects number/boolean values and lists `restoreMode` / `restoreSourceJobId`; - how the client-supplied key in the nested-value error message is bounded or sanitized before it reaches the ERROR log; - whether the `buildRequestParams(Map, Map)` overload was renamed or kept, and if kept, why. Once I have that I'll re-review 98a2be8 against all eight points. <!-- streview-comment:2129 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
