DanielLeens commented on PR #12922: URL: https://github.com/apache/seatunnel/pull/12922#issuecomment-6514214254
Thanks @SEZ9. I read the complete author discussion and rechecked the pointers from my latest full review, so there is no need to repost the truncated table for my benefit. The null/empty parameter tests, blank-ID handling and number-shape checks are present, and the paired REST descriptions include the expanded parameter contract. My full review already reconciles those points. The remaining partial-submission boundary is specifically a string job ID that passes map preparation but fails later numeric parsing after an earlier entry can be submitted; the HTTP-level mixed valid/invalid request must prove zero submissions, not just a validator result. Please retain that existing shared blocker and my two current requests: cover the actual batch HTTP boundary in RestApiIT, and document the validation helper boundary at JobInfoService.java:525. Build is now green, which clears the old missing-CI snapshot but does not close those source/test requests. This is a discussion reply on the unchanged head, not another full review. Snapshot 2026-10-30T03:23:54.149062+00:00: head `98a2be84ed7c36017e9e297a7b0f593661a7a53b`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40847703123/job/123852198075) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123861377260) = `SUCCESS`. Base `dev`; comparison `diverged`, ahead 8, behind 8; merge state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. This is an unchanged-head discussion/CI clarification, not a new complete source review, an effective approval or a dismissal of historical requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
