SEZ9 commented on PR #12101: URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6538910005
Thanks for the detailed walkthrough on head `55831abaef1e1aac58988977c1da8e73a27d9417`. On the eight earlier points: the explanations for F1 (raw cause dropped in JSON mode, kept for text diagnostics), F2 (Jackson nodes in `ConfigValidationResult.toJson`), F3 (null-safe sanitizer plus non-null fallback), F5 (text-mode path-error classification change recorded as intentional), F6 (success serialization outside the validation catch) and F7 (`schemaVersion`/`valid`/`phase`/`errors` documented) all sound reasonable, but I can only mark them resolved against the diff itself. Could you point me to the corresponding changed hunks in this PR so I can verify? For F4, if the documented contract explicitly allows diagnostic stdout alongside the result, I won't block on it; please just make sure the docs tell callers how to pick out the JSON record. F8 stays low/non-blocking. On CI: Signal pull request update (run 40168278125, job 121480735658) is SUCCESS, while Build (121486172557) is ACTION_REQUIRED. Please start or link the existing fork Build for this head (enabling workflows only if they are disabled); no empty commit or unrelated changes are needed. <!-- streview-comment:2171 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
