SEZ9 commented on issue #13075: URL: https://github.com/apache/seatunnel/issues/13075#issuecomment-6553245922
Thanks for the detailed report and reproduction. Agreed: the `toUpperCase()` calls in `SqlServerTypeConverter.convert` and `SqlServerURLParser.parse` should use a fixed, locale-independent conversion instead of the JVM default locale. Since you offered to submit a PR, please go ahead. While you are at it, it would be worth checking the rest of `connector-jdbc` for other locale-sensitive case conversions. For regression coverage, a test that exercises the type converter and URL parser under the Turkish locale (for example, running `SqlServerTypeConverterTest` with `-Duser.language=tr -Duser.country=TR`) would be helpful. You verified this on `dev`; could you also confirm whether the latest release is affected? That helps decide whether a backport is needed. <!-- streview-comment:2197 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
