SEPURI-SAI-KRISHNA commented on issue #13075:
URL: https://github.com/apache/seatunnel/issues/13075#issuecomment-6554179590
Thanks for the review. The fix is up in #13077.
**Latest release:** affected. I ran the same reproduction against the
released `connector-jdbc` jars from Maven Central, 3.0.0 and 2.3.13, on JDK 17.
Under `tr-TR` and `az-AZ` both versions fail `convert("int")` with `'SqlServer'
unsupported convert type 'İNT'` (and `BİGİNT`, `DATETİME2` for `bigint` and
`datetime2`), and the `instanceName` URL comes back as
`jdbc:sqlserver://localhost:1433;instanceName=SQLEXPRESS;encrypt=false`, port
1433. Under `en-US` both versions are correct.
**Regression tests:** #13077 adds
`SqlServerTypeConverterTest#testConvertDoesNotDependOnTheDefaultLocale` and
`SqlServerURLParserTest#testInstanceNamePropertyDoesNotDependOnTheDefaultLocale`.
They set `tr-TR` and then `az-AZ` as the default locale inside the test and
restore it afterwards, so they run in the normal CI build without extra `-D`
flags.
**Rest of `connector-jdbc`:** on current `dev` (fcb404cd94) there are 53
`toUpperCase()` / `toLowerCase()` calls without a locale under
`connector-jdbc/src/main`.
- 14 are already covered by open PRs: #13063 (`field_ide`, `CatalogUtils`
and `JdbcDialect`), #13076 (MySQL and OceanBase) and #13077 (SQL Server).
- 9 only check whether a query starts with or contains `where`. That word
has no `i`, so the result is the same in every locale.
- The other 30 are mostly the type converters and mappers of other dialects
(Oracle, DB2, DM, Kingbase, IRIS, Xugu, YashanDB, SAP HANA, Snowflake,
Redshift, Hive, Presto, Teradata, Vertica and a few more), plus the Xugu
database name lookup and `CollationBasedSplitter`. Whether each one actually
breaks depends on what case the driver or catalog query returns, so I will
check them one by one and open small follow-ups grouped by dialect for the ones
that do, keeping #13077 to SQL Server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
