SEZ9 commented on issue #13075: URL: https://github.com/apache/seatunnel/issues/13075#issuecomment-6568416499
Thanks for the thorough follow-up, @SEPURI-SAI-KRISHNA. The reproduction against the released 3.0.0 and 2.3.13 `connector-jdbc` jars settles the question: the `'İNT'` / `BİGİNT` / `DATETİME2` failures from `SqlServerTypeConverter.convert` and the `instanceName` URL falling back to port 1433 under `tr-TR` / `az-AZ`, with `en-US` correct, matches the original report, so I am treating this as a confirmed bug rather than an environment quirk. The two regression tests you describe cover both affected call sites, and switching the default locale inside the test rather than via `-D` flags is the right approach so CI exercises them unconditionally. Please just make sure the default locale is restored even when an assertion fails, so it cannot leak into other tests in the same JVM. On scope: keeping #13077 limited to the SQL Server type converter and URL parser, with the remaining `connector-jdbc` call sites handled in the other open PRs, works for me. Your inventory on `dev` (fcb404cd94) is useful to have on record here, and I agree the `where` prefix check in `SqlWhereConditionHelper` is locale-neutral and can stay as-is. I will do the detailed review on #13077 itself. <!-- streview-comment:2221 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
