zephyr45 commented on PR #13060: URL: https://github.com/apache/seatunnel/pull/13060#issuecomment-6545918853
Thanks @DanielLeens — I addressed all three non-blocking recommendations in `21d4cb19`. 1. **Same-generation in-place rescaling:** when a writer is assigned another index's base namespace from the same sink generation, it now fences that assigned namespace but writes under a deterministic relocation namespace (`...r<current-writer>`). A retry from the same checkpoint derives and fences the same relocation namespace. A later stateless writer can therefore reuse its base slot without fencing the relocated live writer. The derivation also avoids any relocation namespace already present in the assigned states. The regression models same-generation 3 -> 2 -> 3: writer 1 receives `g...w2`, relocates it, and stateless writer 2 safely uses `g...w2`. 2. **Unreleased numeric compatibility:** removed the numeric writer-namespace parser and exact-index branch. Tests now use only the final generation-scoped namespace plus the genuinely released legacy `<prefix>-<checkpoint>` form. 3. **Spark speculation:** documented in both English and Chinese that Kafka exactly-once on Spark requires `spark.speculation=false` (the default), because concurrent attempts for one partition share a writer namespace. Validation on Java 11: - Kafka connector unit suite: 146 passed; `KafkaSinkWriterTest` 14/14. - Documentation checks: 7 run, 0 failures/errors (3 skipped). - Affected 16-module dependency reactor: package succeeded. - Repository-wide `spotless:apply`: passed. - Repository-wide skip-tests `verify`: passed. - `git diff --check`: passed. The exact-head Build is queued at https://github.com/zephyr45/seatunnel/actions/runs/41218673502 (head `21d4cb19869a7875f52ba5035e20f177599feaaa`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
