zephyr45 commented on PR #13060: URL: https://github.com/apache/seatunnel/pull/13060#issuecomment-6561957027
Final review follow-ups are pushed in `ba97d640`. Resolved the remaining points from the latest review: - Added the transaction-ID grammar and restore-parser contract documentation in `KafkaSinkWriter`, including the explicit distinction between the contiguous transaction sequence and the engine checkpoint ID. - Hardened the parallel exactly-once batch E2E: exact set/count assertions now run inside a bounded Awaitility retry, so the test no longer treats one consumer read with a 2-second idle cutoff as the final broker state. - Corrected the PR description to the current counts: 147 Kafka connector tests and 15 `KafkaSinkWriterTest` cases. Current-head verification: - Kafka connector unit suite on Java 11: **147/147 passed**. - `KafkaSinkWriterTest`: **15/15 passed**. - Zeta + real Kafka: parallel exactly-once batch and 3-to-2 streaming restore: **2/2 passed**. - Spark + real Kafka: parallel exactly-once batch on Spark 2.4.6 and 3.3.0: **2/2 passed**. - Scoped Spotless for both changed files and `git diff --check`: passed. - Merge-tree check against current `origin/dev`: clean. @SEZ9, could you please re-review and dismiss the outstanding change request if these fixes satisfy it? @DanielLeens, a final maintainer review would also be appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
