88fantasy commented on PR #12210: URL: https://github.com/apache/seatunnel/pull/12210#issuecomment-6567393679
Thanks @DanielLeens for the detailed review. I have pushed the fixes for the four blocking findings in `6b032cf8f`: - **Issue 3:** The heartbeat tests release the blocked send and clean up the callback with bounded waits. They no longer depend on the one-second elapsed-time assertion. - **Issue 5:** The shaded-artifact test redirects child output to a temporary file, waits with a deadline, and uses bounded process cleanup. It also covers a stuck driver and a process that cannot be stopped. - **Issue 4:** Flink no longer attaches job-wide accumulator totals to individual output datasets. This applies to single-output jobs as well, because the available information does not reliably establish ownership of the totals. The English and Chinese docs describe this behavior. - **Issue 6:** Flink isolates ordinary dataset extraction failures per connector, logs the connector type and position without configuration values or exception messages, and continues preparing the job. A test uses a real SPI-loaded extractor that throws during `FlinkExecution` construction; the plugin processors themselves are test doubles. On this commit, JDK 11 Spotless and the full-reactor `-DskipTests verify` passed. The focused run passed **94 tests**, including **4 shaded-artifact integration tests**, with no failures or skips. The current-head fork [Build](https://github.com/88fantasy/seatunnel/actions/runs/41375997249) is still in progress. Earlier isolated Flink tests covered attached, detached and two-sink Paimon jobs, but those tests were not repeated on this commit. The non-blocking timeout wording and retry-assertion findings, as well as alignment with the newer shared VM-error policy, remain follow-up work. Could you please re-review the updated head? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
