SEZ9 commented on PR #12443:
URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6258983141
Thanks for the follow-ups, @hutiefang76.
Where the previous points stand from my side:
- **F1 / F5 (decryptConfig re-parse, fix private to RestUtil):** Your
comments describe the quoting and decryption behavior, but I can't confirm from
the thread how the normalisation is now wired into the shared Map-to-Config
path. Could you point me at the relevant change so I can verify the fix applies
on every `ConfigFactory.parseMap` call, including decryption?
- **F2 (docs):** Thanks for tightening the EN/ZH wording in 5969894235. I'll
re-read the actual docs text on the current head before closing this.
- **F3 (successfully-parsed keys rewritten):** Treating `->` as an
intentional, documented path separator is fine for compatibility. The finding
also covered embedded quotes being stripped and leading/trailing whitespace
being trimmed for keys the parser accepts — could you confirm whether that is
also documented or otherwise handled?
- **F4 / F6 (test coverage):** The two embedded REST integration cases on
bdcfccdb1b80 (`testSubmitJobWithHoconFormatAndQuotedLiteralKey`,
`testSubmitJobWithJsonFormat`) help. Could you confirm (or add) coverage for a
regex key passing through decryption, a key whose only offending token is `$`,
`:` or `${...}`, and an escape round-trip with `"`/`\` in a key? If these
already exist, just point me at them.
- **F7 (title prefix):** Please rename the PR title from `[Fix][Core]` to
`[Fix][Zeta]`, since the change is in the engine module.
Also, as you noted, remote CI is still open; we gate on a green CI run for
the current head, so please get that through as well.
Once the above are confirmed and CI is green, I'm happy to take another look.
<!-- streview-comment:1874 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
