SEZ9 commented on issue #12809: URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-6594311409
@Nikk8091 thanks for the detailed FilterRowKind claim and for checking the current dev page against `FilterRowKindTransformFactory` / `FilterRowKinkTransformConfig` first. I don't see another FilterRowKind claim or an open rewrite PR in this thread either, so please go ahead with that scope. The plan you outlined matches what we want for this tracker: a single documentation-only PR against `dev` touching `docs/en/transforms/filter-rowkind.md` and `docs/zh/transforms/filter-rowkind.md`, with the full options table (including `table_transform`, `table_match_regex` and `rule_match_mode`), the accepted row kinds and the non-empty include/exclude rule constraint, per-option explanations, and the three example shapes you listed (transform-level rule, combined transform/per-table rules, `table_transform`-only). A few concrete asks when you open the PR: - Keep the EN and ZH pages in sync (same options, defaults, and examples), and keep the earlier documentation corrections intact as you said. - For the multi-table resolution behavior, please describe it as the current implementation and existing tests actually behave, and note in the PR description which tests you checked so reviewers can verify quickly. - If you find a mismatch between the code and the intended behavior while doing that check, raise it as a separate issue rather than folding a code change into the doc PR. - Link the PR back to this tracker so the claim is visible to others. Thanks for picking this up! <!-- streview-comment:2245 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
