DanielLeens commented on PR #12079:
URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6616920734

   Thanks @SEZ9. I think this latest list reflects an older snapshot of the PR: 
the head is still `67f3bde2506a`, and your own follow-up on 2026-11-01 already 
marked F5, F6 and F7 as resolved. I re-checked F1 and F2 against the current 
head (static read only), and both are covered with tests:
   
   - **F1 (duplicate default output IDs):** 
`TransformDependencyScheduler.java:116` removes the `waitingByInputId` entry 
once per output ID, so two producers on `DEFAULT_ID` cannot double-release a 
join. Tests: 
`ConfigParserUtilTest.testDuplicateOutputsReleaseEachMissingInputOnlyOnce` 
(L356), `testDuplicateOutputsCannotHideUnproducedInput` (L260), and 
`MultipleTableJobConfigParserTest.testDuplicateUnnamedOutputsWaitForOtherJoinInput`
 (L773), which asserts the join's real upstreams and scheduling order.
   - **F2 / F4 (terminal fallback):** a multi-transform job whose last 
transform omits `plugin_input` still resolves through the terminal fallback. 
Tests: 
`MultipleTableJobConfigParserTest.testTerminalOmittedInputUsesNamedTransformSchemaAndEdge`
 (L728) and `testOmittedInputPrefersExistingDefaultOverLastNamedOutput` (L733), 
plus `testTransformEvaluationOrderKeepsLegacySinkFallbackOnTerminalTransform` 
(L196).
   - **F6:** `ConfigParserUtilTest.testSimpleGraphRejectsExplicitSelfCycle` 
(L221) and `testRejectsSelfCycleInComplexGraph` (L92).
   - **F7:** the migration note is in 
`docs/en/introduction/concepts/incompatible-changes.md`, with the zh mirror.
   - **F3 / F5 / F8:** runtime parsing and dry-run share 
`TransformDependencyScheduler`; reusing the scheduled output ID in runtime 
parsing is the optional follow-up you already marked non-blocking.
   
   If you see a concrete input shape that still fails on this head, please 
share the config and I will trace it. Otherwise, @goutamadwant, no new commit 
is needed for these points; the Apache `Build` check is green on this exact 
head, and what remains is a write-capable maintainer's approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to