DanielLeens commented on PR #13083: URL: https://github.com/apache/seatunnel/pull/13083#issuecomment-6646047120
Thanks @sharpca for the table, that makes the pattern easy to follow, and sorry these runs keep landing on different containers. I looked at the newest failure myself. In attempt 1 of [run 41880443702](https://github.com/sharpca/seatunnel/actions/runs/41880443702) on `de80d166`, `updated-modules-integration-test-part-7 (17)` failed on `JdbcHanaIT`, and the cause is `ContainerLaunchException: Container startup failed for image saplabs/hanaexpress:2.00.076.00.20240701.1`: the container exited with code 3 before it logged `Startup finished!`. No SeaTunnel job ran in that class. So even though this PR touches `SapHanaTypeConverter`, that run never reached the converter, and I agree it is infrastructure. The other shards in that attempt passed. On your question: I agree you should not keep doing full 5-6 hour runs. Rerunning only the failed job is the cheapest step, and attempt 2 of the same run (started 23:27Z, only the part-7 shard is running) is already doing that, so nothing more is needed from you right now. If it passes, that run is green on this exact head and I will update my review to approve straight away. If it hits yet another unrelated container, please just rerun that one job again; there is no need for a new dispatch or an empty commit. About merging on code-level evidence alone: I only have read access here, so that call belongs to the committers. My view stays the same: the source is ready, and the `JdbcMysqlSplitIT` case is already shown passing on real MySQL in run 41730993933. Because the PR touches about 30 dialect converters, I would still like one green run on the head before approving. Thanks for your patience! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
