DanielLeens commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6646305655
Thanks @Rangsh for the complete pointers. I checked the unchanged head: RequestFuture.get():97-108 delegates to the bounded timed get and wraps TimeoutException; WALWorkHandler.executeResponse:130 onward guards both cache lookup and future.done, including an expired/missing future. IMapFileStorage:394-417 uses one batch deadline and still collects already-completed futures with get(0); :378-385 and :418-428 keep timeout stack traces at DEBUG. The module pom.xml:81-90 explicitly includes test-scoped mockito-junit-jupiter for the renamed HdfsWriterFlushCallCountTest. These are existing protections on this head, not fixes waiting to be pushed. My technical approval stands. The exact-head fork Build 41278819019 is successful, while Apache check adoption and effective maintainer review remain separate. The pre-existing private-field spelling is optional cleanup; no new commit is requested merely to repeat these answers. @SEZ9 can now reconcile the outstanding review against these concrete source locations. This is an unchanged-head discussion/CI clarification, not another full source review or a claim of local runtime testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
