Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6567902491
@SEZ9 pointers for the items you are still reading on `ef99d22d1`. F4 and F2 were already covered above, so I will not repeat them. **F1.** `Future` requires the untimed `get()`, so it cannot be removed. It now delegates to the timed `get` using the configured `writDataTimeoutMilliseconds` (the field name is missing the `e`; the config key is `writeDataTimeoutMilliseconds`). A timeout throws instead of blocking forever: https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/future/RequestFuture.java#L84-L108 **F3.** Both callers in this module use the timed `get` and treat timeout as failure: https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/IMapFileStorage.java#L373-L437 **F5.** Mockito is an explicit test dependency of `imap-storage-file`: https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/pom.xml#L81-L90 **F7.** The method-level javadoc on `get(timeout, unit)` states the throw-on-timeout contract: https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/future/RequestFuture.java#L110-L130 **F8.** A timed-out write wait logs one WARN line with the request id and the timeout. The stack trace is logged at DEBUG only, in both `queryExecuteStatus` (L378-L385) and the batch path (L418-L428) of the same `IMapFileStorage.java`. @DanielLeens on the caller outside this module: a permanent block becomes a visible checkpoint-storage failure in `FileMapStore`. `store`, `storeAll`, `delete`, and `deleteAll` propagate a failed `IMapStorage` result, and `persistenceFailure` throws `IMapStorageException` when `isAppendPermanentlyBlocked()` is true: https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/persistence/FileMapStore.java#L98-L129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
